-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide .NET Framework target in the csharp nuget package #3212
Comments
What issues? According to the table netstandard2.0 is compatible with .NET Framework >= 4.6.1. |
It also says
What happens is that it pulls in additional dependencies, like System.Runtime.InteropServices.RuntimeInformation, that needs to be deployed and so on. And perhaps there are additional issues that are not as apparent that causes tricky to resolve issues on client machines. The documentation doesn't say what issues it causes so I'd rather avoid that unknown if I can. |
In this case, maybe it makes sense to use a minimal compatible .NET Framework version, 4.5 or 4.6.1? |
I'm fine with either. It compiles for .net 4.5 so I guess it makes sense to go for that. |
Currently the Antlr4.Runtime.Standard NuGet package only contains a netstandard 2.0 build. If you consume such a package targeting .NET Framework prior to 4.7.2 it adds additional dependencies that causes us some issues. Instead of working around those it would be easier if the C# runtime package included a .NET Framework 4.6.2 target.
<TargetFrameworks>net462;netstandard2.0</TargetFrameworks>
We cannot upgrade to 4.7.2 or newer right now due to outside constraints for some of our projects.
The text was updated successfully, but these errors were encountered: