From 9dffbc7085497ed63ea5a6b5cb5485ed13c33dd3 Mon Sep 17 00:00:00 2001 From: Alessia Bellisario Date: Wed, 31 Jan 2024 09:38:49 -0500 Subject: [PATCH 1/4] fix: remove error thrown by inFlightLinkObservables --- .changeset/wet-jars-laugh.md | 5 +++++ src/core/QueryManager.ts | 9 --------- 2 files changed, 5 insertions(+), 9 deletions(-) create mode 100644 .changeset/wet-jars-laugh.md diff --git a/.changeset/wet-jars-laugh.md b/.changeset/wet-jars-laugh.md new file mode 100644 index 00000000000..c52db26820c --- /dev/null +++ b/.changeset/wet-jars-laugh.md @@ -0,0 +1,5 @@ +--- +"@apollo/client": patch +--- + +Remove error thrown by `inFlightLinkObservables` intended to be removed before 3.9 release. diff --git a/src/core/QueryManager.ts b/src/core/QueryManager.ts index c8403d1420f..a65a1d19751 100644 --- a/src/core/QueryManager.ts +++ b/src/core/QueryManager.ts @@ -188,15 +188,6 @@ export class QueryManager { if ((this.onBroadcast = onBroadcast)) { this.mutationStore = Object.create(null); } - - // TODO: remove before we release 3.9 - Object.defineProperty(this.inFlightLinkObservables, "get", { - value: () => { - throw new Error( - "This version of Apollo Client requires at least @apollo/experimental-nextjs-app-support version 0.5.2." - ); - }, - }); } /** From f7b4dbc8b756bcd732a6bf98bdfaf6fc857df1b1 Mon Sep 17 00:00:00 2001 From: Alessia Bellisario Date: Wed, 31 Jan 2024 11:12:33 -0500 Subject: [PATCH 2/4] chore: update line references in .api-reports --- .api-reports/api-report-core.md | 2 +- .api-reports/api-report-react.md | 2 +- .api-reports/api-report-react_components.md | 2 +- .api-reports/api-report-react_context.md | 2 +- .api-reports/api-report-react_hoc.md | 2 +- .api-reports/api-report-react_hooks.md | 2 +- .api-reports/api-report-react_internal.md | 2 +- .api-reports/api-report-react_ssr.md | 2 +- .api-reports/api-report-testing.md | 2 +- .api-reports/api-report-testing_core.md | 2 +- .api-reports/api-report-utilities.md | 2 +- .api-reports/api-report.md | 2 +- 12 files changed, 12 insertions(+), 12 deletions(-) diff --git a/.api-reports/api-report-core.md b/.api-reports/api-report-core.md index 24cf06f5a60..4d86ebc77c6 100644 --- a/.api-reports/api-report-core.md +++ b/.api-reports/api-report-core.md @@ -2226,7 +2226,7 @@ interface WriteContext extends ReadMergeModifyContext { // src/core/ObservableQuery.ts:117:5 - (ae-forgotten-export) The symbol "QueryInfo" needs to be exported by the entry point index.d.ts // src/core/QueryManager.ts:124:5 - (ae-forgotten-export) The symbol "MutationStoreValue" needs to be exported by the entry point index.d.ts // src/core/QueryManager.ts:158:5 - (ae-forgotten-export) The symbol "LocalState" needs to be exported by the entry point index.d.ts -// src/core/QueryManager.ts:399:7 - (ae-forgotten-export) The symbol "UpdateQueries" needs to be exported by the entry point index.d.ts +// src/core/QueryManager.ts:390:7 - (ae-forgotten-export) The symbol "UpdateQueries" needs to be exported by the entry point index.d.ts // src/core/watchQueryOptions.ts:269:2 - (ae-forgotten-export) The symbol "IgnoreModifier" needs to be exported by the entry point index.d.ts // src/core/watchQueryOptions.ts:269:2 - (ae-forgotten-export) The symbol "UpdateQueryFn" needs to be exported by the entry point index.d.ts // src/link/http/selectHttpOptionsAndBody.ts:128:32 - (ae-forgotten-export) The symbol "HttpQueryOptions" needs to be exported by the entry point index.d.ts diff --git a/.api-reports/api-report-react.md b/.api-reports/api-report-react.md index 3489e1e54c3..7ffee6ffb39 100644 --- a/.api-reports/api-report-react.md +++ b/.api-reports/api-report-react.md @@ -2391,7 +2391,7 @@ interface WatchQueryOptions(inter // src/core/ObservableQuery.ts:117:5 - (ae-forgotten-export) The symbol "QueryInfo" needs to be exported by the entry point index.d.ts // src/core/QueryManager.ts:124:5 - (ae-forgotten-export) The symbol "MutationStoreValue" needs to be exported by the entry point index.d.ts // src/core/QueryManager.ts:158:5 - (ae-forgotten-export) The symbol "LocalState" needs to be exported by the entry point index.d.ts -// src/core/QueryManager.ts:399:7 - (ae-forgotten-export) The symbol "UpdateQueries" needs to be exported by the entry point index.d.ts +// src/core/QueryManager.ts:390:7 - (ae-forgotten-export) The symbol "UpdateQueries" needs to be exported by the entry point index.d.ts // src/core/types.ts:174:3 - (ae-forgotten-export) The symbol "MutationQueryReducer" needs to be exported by the entry point index.d.ts // src/core/types.ts:203:5 - (ae-forgotten-export) The symbol "Resolver" needs to be exported by the entry point index.d.ts // src/core/watchQueryOptions.ts:269:2 - (ae-forgotten-export) The symbol "IgnoreModifier" needs to be exported by the entry point index.d.ts diff --git a/.api-reports/api-report-react_ssr.md b/.api-reports/api-report-react_ssr.md index a6057e4a7eb..477152f332d 100644 --- a/.api-reports/api-report-react_ssr.md +++ b/.api-reports/api-report-react_ssr.md @@ -1641,7 +1641,7 @@ interface WatchQueryOptions(it: (...args: TArgs // src/core/ObservableQuery.ts:117:5 - (ae-forgotten-export) The symbol "QueryInfo" needs to be exported by the entry point index.d.ts // src/core/QueryManager.ts:124:5 - (ae-forgotten-export) The symbol "MutationStoreValue" needs to be exported by the entry point index.d.ts // src/core/QueryManager.ts:158:5 - (ae-forgotten-export) The symbol "LocalState" needs to be exported by the entry point index.d.ts -// src/core/QueryManager.ts:399:7 - (ae-forgotten-export) The symbol "UpdateQueries" needs to be exported by the entry point index.d.ts +// src/core/QueryManager.ts:390:7 - (ae-forgotten-export) The symbol "UpdateQueries" needs to be exported by the entry point index.d.ts // src/core/types.ts:174:3 - (ae-forgotten-export) The symbol "MutationQueryReducer" needs to be exported by the entry point index.d.ts // src/core/types.ts:203:5 - (ae-forgotten-export) The symbol "Resolver" needs to be exported by the entry point index.d.ts // src/core/watchQueryOptions.ts:269:2 - (ae-forgotten-export) The symbol "IgnoreModifier" needs to be exported by the entry point index.d.ts diff --git a/.api-reports/api-report-testing_core.md b/.api-reports/api-report-testing_core.md index 202108f79c7..0243870d739 100644 --- a/.api-reports/api-report-testing_core.md +++ b/.api-reports/api-report-testing_core.md @@ -1660,7 +1660,7 @@ export function withWarningSpy(it: (...args: TArgs // src/core/ObservableQuery.ts:117:5 - (ae-forgotten-export) The symbol "QueryInfo" needs to be exported by the entry point index.d.ts // src/core/QueryManager.ts:124:5 - (ae-forgotten-export) The symbol "MutationStoreValue" needs to be exported by the entry point index.d.ts // src/core/QueryManager.ts:158:5 - (ae-forgotten-export) The symbol "LocalState" needs to be exported by the entry point index.d.ts -// src/core/QueryManager.ts:399:7 - (ae-forgotten-export) The symbol "UpdateQueries" needs to be exported by the entry point index.d.ts +// src/core/QueryManager.ts:390:7 - (ae-forgotten-export) The symbol "UpdateQueries" needs to be exported by the entry point index.d.ts // src/core/types.ts:174:3 - (ae-forgotten-export) The symbol "MutationQueryReducer" needs to be exported by the entry point index.d.ts // src/core/types.ts:203:5 - (ae-forgotten-export) The symbol "Resolver" needs to be exported by the entry point index.d.ts // src/core/watchQueryOptions.ts:269:2 - (ae-forgotten-export) The symbol "IgnoreModifier" needs to be exported by the entry point index.d.ts diff --git a/.api-reports/api-report-utilities.md b/.api-reports/api-report-utilities.md index 715d0827a56..24248cc6669 100644 --- a/.api-reports/api-report-utilities.md +++ b/.api-reports/api-report-utilities.md @@ -2635,7 +2635,7 @@ interface WriteContext extends ReadMergeModifyContext { // src/core/ObservableQuery.ts:117:5 - (ae-forgotten-export) The symbol "QueryInfo" needs to be exported by the entry point index.d.ts // src/core/QueryManager.ts:124:5 - (ae-forgotten-export) The symbol "MutationStoreValue" needs to be exported by the entry point index.d.ts // src/core/QueryManager.ts:158:5 - (ae-forgotten-export) The symbol "LocalState" needs to be exported by the entry point index.d.ts -// src/core/QueryManager.ts:399:7 - (ae-forgotten-export) The symbol "UpdateQueries" needs to be exported by the entry point index.d.ts +// src/core/QueryManager.ts:390:7 - (ae-forgotten-export) The symbol "UpdateQueries" needs to be exported by the entry point index.d.ts // src/core/types.ts:174:3 - (ae-forgotten-export) The symbol "MutationQueryReducer" needs to be exported by the entry point index.d.ts // src/core/types.ts:203:5 - (ae-forgotten-export) The symbol "Resolver" needs to be exported by the entry point index.d.ts // src/core/watchQueryOptions.ts:269:2 - (ae-forgotten-export) The symbol "IgnoreModifier" needs to be exported by the entry point index.d.ts diff --git a/.api-reports/api-report.md b/.api-reports/api-report.md index 9040bd40123..0a415adcd95 100644 --- a/.api-reports/api-report.md +++ b/.api-reports/api-report.md @@ -3071,7 +3071,7 @@ interface WriteContext extends ReadMergeModifyContext { // src/core/ObservableQuery.ts:117:5 - (ae-forgotten-export) The symbol "QueryInfo" needs to be exported by the entry point index.d.ts // src/core/QueryManager.ts:124:5 - (ae-forgotten-export) The symbol "MutationStoreValue" needs to be exported by the entry point index.d.ts // src/core/QueryManager.ts:158:5 - (ae-forgotten-export) The symbol "LocalState" needs to be exported by the entry point index.d.ts -// src/core/QueryManager.ts:399:7 - (ae-forgotten-export) The symbol "UpdateQueries" needs to be exported by the entry point index.d.ts +// src/core/QueryManager.ts:390:7 - (ae-forgotten-export) The symbol "UpdateQueries" needs to be exported by the entry point index.d.ts // src/core/watchQueryOptions.ts:269:2 - (ae-forgotten-export) The symbol "IgnoreModifier" needs to be exported by the entry point index.d.ts // src/core/watchQueryOptions.ts:269:2 - (ae-forgotten-export) The symbol "UpdateQueryFn" needs to be exported by the entry point index.d.ts // src/link/http/selectHttpOptionsAndBody.ts:128:32 - (ae-forgotten-export) The symbol "HttpQueryOptions" needs to be exported by the entry point index.d.ts From 2c37367030185ebed0ebbe8c42a88bd681b13ca1 Mon Sep 17 00:00:00 2001 From: alessbell Date: Wed, 31 Jan 2024 16:14:42 +0000 Subject: [PATCH 3/4] Clean up Prettier, Size-limit, and Api-Extractor --- .size-limits.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.size-limits.json b/.size-limits.json index ca5d4c24594..5cf8f6bd825 100644 --- a/.size-limits.json +++ b/.size-limits.json @@ -1,4 +1,4 @@ { - "dist/apollo-client.min.cjs": 39149, - "import { ApolloClient, InMemoryCache, HttpLink } from \"dist/index.js\" (production)": 32647 + "dist/apollo-client.min.cjs": 39058, + "import { ApolloClient, InMemoryCache, HttpLink } from \"dist/index.js\" (production)": 32554 } From 6cc0999a3973526e9992da38cf3b43790bba1074 Mon Sep 17 00:00:00 2001 From: alessbell Date: Wed, 31 Jan 2024 16:21:57 +0000 Subject: [PATCH 4/4] Clean up Prettier, Size-limit, and Api-Extractor --- .size-limits.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.size-limits.json b/.size-limits.json index 44d275b37a4..f2fb4219418 100644 --- a/.size-limits.json +++ b/.size-limits.json @@ -1,4 +1,4 @@ { - "dist/apollo-client.min.cjs": 39153, - "import { ApolloClient, InMemoryCache, HttpLink } from \"dist/index.js\" (production)": 32652 + "dist/apollo-client.min.cjs": 39061, + "import { ApolloClient, InMemoryCache, HttpLink } from \"dist/index.js\" (production)": 32559 }