Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_ecs: allow to specify kernel when creating the ecsOptimizedImage #29800

Open
2 tasks
segundovolante opened this issue Apr 11, 2024 · 3 comments
Open
2 tasks
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@segundovolante
Copy link

Describe the feature

Current CDK api does not allow to specify the kernel version, and you end up with 4.14 which is marked as EOL Jan 2024.

This page says 4.14 has reached EOL: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-optimized_AMI.html

API link: https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ecs.EcsOptimizedImage.html

It would help if:

Use Case

I want to create an ECS autoscaling group with the recommended kernel or using another supported ami from the ECS optimized image.

Proposed Solution

Option 1: update the api to use the recommended kernel version (5.10)
Option 2: allow users to pass the kernel version to use, as the AMI exists.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.137.0

Environment details (OS name and version, etc.)

AL2

@segundovolante segundovolante added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 11, 2024
@github-actions github-actions bot added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Apr 11, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Apr 11, 2024
@khushail
Copy link
Contributor

Thanks @segundovolante for requesting this feature. This totally makes sense!

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Apr 11, 2024
@Konosh93
Copy link
Contributor

it could be passed like in this construct: https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ec2.AmazonLinux2Kernel.html

I concur with the proposal to allow manual specification of the kernel version in ecsOptimizedImage. While updating the default kernel version to 5.10 might seem beneficial, it does carry the risk of introducing breaking changes for current users.

Additionally, changing the default kernel would necessitate updates to a large number of integration tests

@segundovolante
Copy link
Author

Yeah, I agree that the better option long term is to allow to specify the kernel as an optional parameter. This would behave similar to the ec2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

3 participants