Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKv3-05: Update @aws-cdk-testing/cli-integ #29837

Open
Tracked by #29694
TheRealAmazonKendra opened this issue Apr 15, 2024 · 0 comments
Open
Tracked by #29694

SDKv3-05: Update @aws-cdk-testing/cli-integ #29837

TheRealAmazonKendra opened this issue Apr 15, 2024 · 0 comments
Assignees
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@TheRealAmazonKendra
Copy link
Contributor

Context

The AWS SDK V2 is being deprecated. We need to remove all uses of it from the CDK.

Task Description

Remove use of sdkv2 in @aws-cdk-testing/cli-testing.

Used to make a custom client in:

  • lib/aws.ts
  • lib/staging/codeartifact.ts

These clients are used extensively in this package.

Considerations

There is already a test that fails silently (cdk import). Each test may need to be manually verified and updated to ensure that this doesn't occur in other places as well. Test updates may also be required.

Acceptance Criteria

  1. All tests (unit and integ) pass using sdkv3.
  2. No instances of sdkv2 are still in use in this package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants