Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKv3-08: Update @aws-cdk/integ-tests-alpha #29839

Closed
Tracked by #29694
TheRealAmazonKendra opened this issue Apr 15, 2024 · 3 comments
Closed
Tracked by #29694

SDKv3-08: Update @aws-cdk/integ-tests-alpha #29839

TheRealAmazonKendra opened this issue Apr 15, 2024 · 3 comments
Assignees

Comments

@TheRealAmazonKendra
Copy link
Contributor

Context

The AWS SDK V2 is being deprecated. We need to remove all uses of it from the CDK.

Task Description

Ensure that the integ test (and integ runner) construct is only making calls to sdkv3.

Acceptance Criteria

  1. There are no uses of sdkv2 in this package.
  2. All tests (unit and integ) pass after the change has been made (ensure that the resources behave as expected and not that they just deploy, some manual verification may be required).
@SankyRed
Copy link
Contributor

Upon investigating the update from SDK v2 to v3 for the @aws-cdk/integ-tests-alpha module, I noticed there are no references to sdk-v2 in the code. Additionally, all references to the aws-sdk-v2-to-v3-adapter have been updated in this PR, and also all the references are pointing to v3 handler imports such as @aws-sdk/client-s3. I've tested the changes and everything appears to be functioning correctly.

Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants