NETWORK_TENDERLY overrides the original NETWORK

[barakman]

Bug Description

In file utils.py, the following action overrides the original network configured by the user:

        if 'tenderly' in rpc_url:
            cfg.NETWORK = cfg.NETWORK_TENDERLY

Subsequently, there is no way to handle the execution in Tenderly in the exact same way it is handled outside of Tenderly.

For example, in file TxHelpers.py currently under PR #542:

        if self.cfg.NETWORK == self.cfg.NETWORK_ETHEREUM:
            self.use_access_list = True
            self.send_transaction = self._send_private_transaction
        else:
            self.use_access_list = False
            self.send_transaction = self._send_regular_transaction

The results of running on Ethereum are:

+------------------+-------------+-------------+
|                  | Transaction | Access List |
+------------------+-------------+-------------|
| With Tenderly    | Regular     | Not applied |
+------------------+-------------+-------------+
| Without Tenderly | Private     | Applied     |
+------------------+-------------+-------------+

Private transactions cannot be used in Tenderly, so testing here is incomplete but there's no other option.
But access lists CAN be used in Tenderly, so there IS an option here to improve the testing of Ethereum via Tenderly.

Severity

Medium

Solution Guidelines

Instead of NETWORK_TENDERLY being one of the values permitted for Config.NETWORK, the Config class should define an additional variable named IS_TENDERLY or similar.

This change might subsequently require a bunch of other changes across the codebase.