[CLOSED] improvements to file system events processing for search #10970
Comments
|
Should avoid doing code reviews when I am tired 😴 👍 Nice work |
|
👍 |
|
Pushed some changes, |
|
|
|
|
|
Used it all day without any issues and Brackets did feel snappier. Great job once again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Wednesday Nov 09, 2016 at 05:16 GMT
Originally opened as adobe/brackets#12885
Hi guys, I've reported elsewhere that my db dump script crashes both brackets (white-screen) and also brackets-electron. This is the work done to fix that (and I can confirm that with this fix there's no crash when running my script anymore) - it's not final and I'd like to have it reviewed before working on little things as docs and similar.
There're two main things, first aggregate duplicate events and debounce for a short while before processing. My script quickly deletes and creates back a lot of stuff, before this change some of the directories were removed and added back to search multiple times. With debouncing it's only once after script is done.
Second, no less important thing is fixing calls to
filesChangedandfilesRemovedfunctions. In case of my script these two were called about 1000 times with an array of size 1 which cause a lot of trouble for IPC connection in electron and socket connection in regular brackets. With the fix these are now properly called.Marking this as high-priority because it fixes brackets completely crashing in some cases.
zaggino included the following code: https://github.com/adobe/brackets/pull/12885/commits
The text was updated successfully, but these errors were encountered: