FileSystem and PreferencesManager circular dependencies

[core-ai-bot]

Issue by ficristo
Monday May 16, 2016 at 18:26 GMT
Originally opened as adobe/brackets#12427

---

In adobe/brackets#12190 I've tried to add some preferences to the file system.
But I think I've incurred in some circular deps problem.
I was able to remove the dep of FileSystem in the PreferencesManager, but, after it, I think I hit the problem in the PreferencesBase.
Any way to workaround this problem?

[core-ai-bot]

Comment by ficristo
Monday Jun 13, 2016 at 10:23 GMT

---

The only workaround is probabily change how modules are exported.
Related: adobe/brackets#1065

[core-ai-bot]

Comment by ficristo
Thursday Dec 29, 2016 at 16:52 GMT

---

I wanted to use the PreferencesManager in filesystem again, and didn't work... again.
If we want to make the 30000 file limit configurable, I think we need a solution here.
@redmunds do you have some ideas?

[core-ai-bot]

Comment by redmunds
Sunday Jan 01, 2017 at 19:26 GMT

---

@ficristo My VS is currently out-of-sync so I can't build latest Brackets, but I think you can set options.maxEntries prior to this call:

            this.projectRoot.visit(allFilesVisitor, options, function (err) {

in ProjectModel.js line 449. I think you can get value from preferences here without creating a circular dependency. How does that work?

[core-ai-bot]

Comment by ficristo
Thursday Jan 05, 2017 at 20:27 GMT

---

That should work for the initial scan (at least I can use the PreferencesManager).
We use the visit function in other places like in ScopeManager: don't we risk to run again in the 30000 limit?

[core-ai-bot]

Comment by redmunds
Thursday Jan 05, 2017 at 21:01 GMT

---

Yes, we'd need to pass it in there as well.