-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLOSED] Update notification is no longer modal #4662
Comments
Comment by peterflynn Nominated for Sprint 31 since it was just introduced in 30. |
Comment by RaymondLim
|
Comment by peterflynn Oops, forgot to add to Trello bug card. Added now. |
Comment by TomMalbran Yes, it was a dirty fix, and unfortunately, it can't be fixed in CSS, so we might need a JS solution. We will also need to focus the dialog to fix the other issue. I haven't seen any issue with the z-index. |
Comment by RaymondLim FBNC to |
Comment by peterflynn Confirmed fixed |
Issue by peterflynn
Thursday Sep 05, 2013 at 00:02 GMT
Originally opened as adobe/brackets#5062
if (_buildNumber === 0 && !force)
block (lines 275-278) -- so the block inside never runsif (force || allUpdates[0].buildNumber > _lastNotifiedBuildNumber)
test (line 294) -- so the block inside always runsforce = true;
at the top of checkForUpdate().Result:
Update notification dialog appears but there's no dark gray "shield" behind it.
Blinking cursor is still in the editor area, and if you type it will modify the editor.
However, clicking/scrolling anywhere is still blocked, along with editor shortcuts like Ctrl+D or Ctrl+Z.
Hitting Esc still closes the dialog, but hitting Enter does not.
Expected:
Gray shield and all keystrokes go only to the dialog, same as if you show it via Help > Check for Updates.
I think the typing still working & the missing shield are both regressions due to PR #4714. Older builds may have shown a blinking cursor in the editor still, but I don't think typing would have actually done anything.
I think the problem is caused by the update popping up before the working set is restored, so the editor grabs focus from the dialog after the dialog is shown. (Not sure how it breaks the shield visuals, though -- especially since some sort of invisible shield is still clearly in place).
The text was updated successfully, but these errors were encountered: