-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLOSED] integration of code-folding extension into brackets #9494
Comments
Comment by Florian-R Out of curiosity, any reason to not keep this as an extension? |
Comment by prksingh
|
Comment by abose
|
Comment by Florian-R
|
Comment by thehogfather
|
Comment by ryanstewart
|
Comment by ryanstewart A couple of things we want to do as part of the merge:
Open question here: Do we allow separate code folding preferences per project? or just globally? or per file? |
Comment by MiguelCastillo
I did not realize how big your extension was! But I did a quick pass and it seems that one glaring inconsistency is the mix of spaces/tabs and that lots of the function are defined right in the Really happy this is coming in. |
Comment by thehogfather
|
Comment by MarcelGerber You should probably merge your translations (at least the English ones) into our main |
Comment by thehogfather I've tidied up and refactored a bit based on the suggestions (thanks all). I've moved preferences to brackets.json and merged the english strings into brackets main strings. There is also an option to disable the extension in the settings dialog (should this be on the menu instead - or as well?). I have translations for fi, fr, ja, nl, pt-br and ru but haven't merged yet. Shall I go ahead and merge those? |
Comment by nethip
|
Comment by abose
|
Comment by MarcelGerber It's probably easier to have a common prefix for all string names, like Furthermore, you should call |
Comment by thehogfather
|
Comment by abose
|
Comment by thehogfather
|
Comment by abose shortcuts Ctrl+Alt+[ and Ctrl+Alt+] 👍 |
Comment by abose
|
Comment by abose The package.json file which has the details for the extension description,author,Contributors etc.. is missing. Could you put that file back in? |
Comment by thehogfather
I can update the version on the registry so that it is only initialised if code-folding doesnt already exist (e.g. by inspecting properties on the CodeMirror object). For those who do not update the extension, the menu items under |
Comment by abose
|
Comment by abose
|
Comment by thehogfather
|
Comment by MiguelCastillo
My take on the code folding extension in the registry is that once this is merged in there isn't really a need for the one in the registry, especially if it is just duplicate functionality. In general, I am not too concerned if someone decides to install an extension for functionality that already exists natively in brackets. However, we should be good citizens and make sure that the integrated extension does not use the same settings as the one that already exists in the registry - to avoid collision. Currently both use Also, I am thinking that this will be announced as a feature for a future release, so lots of people will be aware that code folding is native in brackets :D
|
Comment by abose
Also did you get a chance to look at the code, I was planning to integrate it today for kicking off the string translations and giving sufficient window for unit tests from our side as the 1.3 release is very close now. |
Comment by MiguelCastillo
There are a few changes that seem manageable to make the code fit better with brackets style. I think we are almost there :) |
Comment by thehogfather
|
Comment by abose
|
Issue by thehogfather
Wednesday Mar 25, 2015 at 09:39 GMT
Originally opened as adobe/brackets#10792
Integration of core code-folding extension files into brackets' default extension folder.
thehogfather included the following code: https://github.com/adobe/brackets/pull/10792/commits
The text was updated successfully, but these errors were encountered: