Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of Git for Windows #101

Open
VladimirZhilyakov opened this issue Sep 25, 2015 · 3 comments
Open

Support of Git for Windows #101

VladimirZhilyakov opened this issue Sep 25, 2015 · 3 comments

Comments

@VladimirZhilyakov
Copy link

Multirust isn't installed in Git for Windows bash (MINGW64_NT-6.1) because /usr/local doesn't exists. Git installer doesn't create such directories. The root is set to git installation directory ("C:\Program Files\Git" by default). Could you please change installation folder to another one? %LOCALAPPDATA% is good enough for one user usage.

@VladimirZhilyakov VladimirZhilyakov changed the title Git for Windows bash support Support of Git for Windows Sep 25, 2015
@brson
Copy link
Owner

brson commented Sep 25, 2015

Thanks for the report. This will require updating the install.sh script I think.

@brson
Copy link
Owner

brson commented Sep 25, 2015

Oh, also probably some compatibility code to deal with existing msys /usr/local installs.

@VladimirZhilyakov
Copy link
Author

Unfortunately $LOCALAPPDATA/multirust isn't in the $PATH. Msys2 defines $PATH as

/usr/local/bin:/usr/bin:/bin:/opt/bin:<user paths>

Git for Windows:

<user home>/bin:/mingw32/bin:/usr/local/bin:/usr/bin:/bin:/mingw32/bin:/usr/bin:<user paths>

/usr/local/bin is in the both paths, but in Git for Windows writing requires admin rights (sudo doesn't exists and doesn't work I suppose). I also don't think, installing to the Git application directory is a good idea.
We could try to install multirust to /usr/local/bin if installer has enough rights to do so or to $HOME/bin if it's in the $PATH. It looks backward compatible and correct for both Windows and Linux.

The issue isn't very critical as multirust can be installed with admin privileges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants