Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multirust default <toolchain> doesn't handle manual uninstallation of a toolchain properly #143

Open
yberreby opened this issue Mar 11, 2016 · 1 comment

Comments

@yberreby
Copy link

$ /Users/yberreby/.multirust/toolchains/nightly/lib/rustlib/uninstall.sh
...
$ multirust default nightly
multirust: using existing install for 'nightly'
multirust: default toolchain set to 'nightly'
$ rustc
/usr/local/bin/rustc: line 120: /Users/yberreby/.multirust/toolchains/nightly/bin/rustc: No such file or directory
/usr/local/bin/rustc: line 120: exec: /Users/yberreby/.multirust/toolchains/nightly/bin/rustc: cannot execute: No such file or directory

I'm pretty sure multirust default nightly should detect that the nightly toolchain is missing, and reinstall it, instead of happily reusing an existing install that doesn't actually exist.

@brson
Copy link
Owner

brson commented Mar 11, 2016

It could do better in this situation for sure.

uninstall.sh leaves some directory structure around (because it assumes it could be uninstalling from e.g /) so multirust sees the directory and assumes it has a toolchain.

One general thing that might improve the errors is for multirustproxy to test that a binary actually exists before running it and print a nicer error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants