Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing to create a build annotation shouldn't fail the pipeline #10

Closed
tessereth opened this issue May 9, 2018 · 0 comments
Closed

Failing to create a build annotation shouldn't fail the pipeline #10

tessereth opened this issue May 9, 2018 · 0 comments

Comments

@tessereth
Copy link
Contributor

tessereth commented May 9, 2018 •
edited
Loading

If the rest of a build succeeds, having the annotation step fail can block later steps in the pipeline (eg deploys). This is not desirable behaviour. Suggested fix:

  1. By default, wrap processing each input in a rescue block, log the exception and continue
  2. By default, wrap the top level run in a rescue block, log the exception and continue
  3. Add a configuration flag to actually fail on errors for people who really want/need it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tessereth