Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected link in header doesn't match selected form #17

Open
8thDay opened this issue Mar 12, 2018 · 2 comments
Open

Selected link in header doesn't match selected form #17

8thDay opened this issue Mar 12, 2018 · 2 comments
Assignees

Comments

@8thDay
Copy link
Contributor

8thDay commented Mar 12, 2018

Regarding the user form (log in/sign up page):
If you click on the form tabs to change between "log in" and "sign up", it would be better if the header links also changed to match the selection.

For example, in the attached image, the "log in" form is selected, the page title correctly says "log in", but the header still shows "sign up" as the active link.

ui-issue--can-header-match-form

@GarrusNapp
Copy link
Contributor

GarrusNapp commented Mar 12, 2018

Selection in header is managed by react-router using activeClassName, therefore the selection is bound to current path, while selection on UserForm component is managed by its state.

I don't see an easy way to fix that and since it's not crucial issue I'd opt for leaving it as it is for now.

@8thDay
Copy link
Contributor Author

8thDay commented Mar 12, 2018

As you say, it isn't crucial, but I'm going to leave the issue open for now, as a "nice to have".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants