Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffs for tag-only edit suggestions can be confusing #1383

Open
cellio opened this issue Aug 22, 2024 · 0 comments
Open

Diffs for tag-only edit suggestions can be confusing #1383

cellio opened this issue Aug 22, 2024 · 0 comments
Labels
area: html/css/js Changes to front-end code complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. priority: medium type: change request New feature or request

Comments

@cellio
Copy link
Member

cellio commented Aug 22, 2024

meta:291273

When a suggested edit changes the body of a post, the review shows the side-by-side diff, as expected. When a suggested edit changes only the tags, however, it shows the body once (nothing to diff), with the green background, and then shows the tags diff. This can lead reviewers to think something in the body changed (and spend time looking for it).

We do want the body to be visible for a review of tag-only changes (how else would you be able to evaluate the change?), but can we show the body with neither green nor pink background and add something like "no changes in body" to guide the reviewer?

@cellio cellio added area: html/css/js Changes to front-end code type: change request New feature or request priority: medium complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. labels Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: html/css/js Changes to front-end code complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. priority: medium type: change request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant