Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread title without comment enables the "create thread" button, but not really #1389

Open
cellio opened this issue Sep 2, 2024 · 0 comments
Labels
area: html/css/js Changes to front-end code complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. priority: low type: bug Something isn't working

Comments

@cellio
Copy link
Member

cellio commented Sep 2, 2024

meta:291583

If you start a comment thread, the "create thread" button starts out disabled. If you enter a comment of the minimum length, the button is enabled. If you don't enter a comment but do enter a thread title (which is optional), the button is enabled. This isn't harmful because clicking the button produces an error directing you back to the comment textbox, but ideally the button state would not be affected by the optional title at all. It should be based only on the comment length.

I'm looking at app/views/comments/_new_thread_modal.html.erb, but I can't quite figure out where the button display state is set.

@cellio cellio added area: html/css/js Changes to front-end code type: bug Something isn't working priority: low complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. labels Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: html/css/js Changes to front-end code complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. priority: low type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant