Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning for Sass 2.0.0 #94

Closed
YannickMol opened this issue May 22, 2021 · 7 comments
Closed

Warning for Sass 2.0.0 #94

YannickMol opened this issue May 22, 2021 · 7 comments

Comments

@YannickMol
Copy link

I am getting the following warning for some of the elements in the framework:

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

node_modules\codyhouse-framework\main\assets\css\base\_mixins.scss 139:18       round-width()
node_modules\codyhouse-framework\main\assets\css\base\_grid-layout.scss 130:27  @import
node_modules\codyhouse-framework\main\assets\css\_base.scss 13:9                @import

Are you aware of this warning and will this be fixed in upcoming release?

Thanks!

@sebastiano-guerriero
Copy link
Contributor

Hi! We will update soon to the new SASS modules system 👍 We're figuring out how to do so without creating issues for users who are not using SASS 2.0

@patrickedqvist
Copy link

A lot of packages are installing dart-sass per default and it's quite easy to get the information that node-sass is deprecated. Maybe create a new major version with breaking changes and keep the current version with some short-term support?

I would love to see the new dart sass version implemented 🤗

@sebastiano-guerriero
Copy link
Contributor

We're running the first tests using dart SASS in CodyFrame. The main issue we've run into: the dart-sass compiler is 2-3x slower compared to the node-sass compiler. It appears the SASS team is working on a potential solution, even though it's not clear when it will be available and what impact it will have on the performance.

More info here: sass/dart-sass#113

Have you experienced the same issue?

@patrickedqvist
Copy link

@sebastiano-guerriero I have only read about it when different frameworks have mentioned that you can use either node-sass and dart-sass with dart-sass being slower. That said, the longer compile time hasn't been causing any frustration in any of our projects which range from small to medium-sized projects.

@sebastiano-guerriero
Copy link
Contributor

@patrickedqvist good to know! 👍

Btw, the SASS team is working on a new package where the compiler is faster: https://www.npmjs.com/package/sass-embedded

@retroriff
Copy link

I am receiving lots of warnings, while I am supposed to be using node-sass instead of dart-sass. May be sass-loader who is triggering those messages?

@claudia-romano
Copy link
Contributor

We just release CodyFrame 3.0 that supports Sass Modules:
https://codyhouse.co/blog/post/codyframe-3-0

We are still supporting CodyFrame v2 for node-sass users:
https://github.com/CodyHouse/codyhouse-framework/tree/v2

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants