Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better scalaVersion handling in MillBuildRootModule #2769

Closed
jilen opened this issue Sep 20, 2023 · 2 comments · Fixed by #2768
Closed

Better scalaVersion handling in MillBuildRootModule #2769

jilen opened this issue Sep 20, 2023 · 2 comments · Fixed by #2768
Milestone
0.11.5

Comments

@jilen
Copy link
Contributor

jilen commented Sep 20, 2023

The meta build use a hardcoded 2.13.10 scala version.
If I want to force it use 2.13.11 (for jdk21), sure I can create mill-build folder and set that version, but then it will use another recursive meta-build which use 2.13.10 again.
@jilen
Copy link
Contributor Author

jilen commented Sep 20, 2023

Seems already addressed #2768 just now!

@lefou lefou mentioned this issue Sep 20, 2023
Merged
@lefou lefou linked a pull request Sep 20, 2023 that will close this issue
Fix some hardcoded scala versions #2768
Merged
@lefou lefou added this to the 0.11.5 milestone Sep 20, 2023
@lefou
Copy link
Member

lefou commented Sep 20, 2023

Fixed. I'll later this day cut a snapshot release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.5
Development

Successfully merging a pull request may close this issue.

Fix some hardcoded scala versions com-lihaoyi/mill
2 participants
@jilen @lefou