Skip to content
This repository has been archived by the owner on Dec 2, 2022. It is now read-only.

Support new CANPacket format sent over USB to the panda #8

Open
incognitojam opened this issue Jan 6, 2022 · 2 comments
Open

Support new CANPacket format sent over USB to the panda #8

incognitojam opened this issue Jan 6, 2022 · 2 comments

Comments

@incognitojam
Copy link
Contributor

Need to add support for new format in latest panda firmwares. Do we need to retain support for old firmwares? Or just introduce a breaking change and update version number accordingly.

Relevant PRs:
commaai/panda#739
@gregjhogan
Copy link
Member

We only need to support the new format. An old version of this library can be used for the old format.

@gregjhogan
Copy link
Member

You can query the CAN packet version:
https://github.com/commaai/panda/blob/f5857bc8fd3e1d2c27df342df85e202c7e844911/python/__init__.py#L405-L412
and raise an error if it is not the correct version:
https://github.com/commaai/panda/blob/f5857bc8fd3e1d2c27df342df85e202c7e844911/python/__init__.py#L110-L113

@pd0wm pd0wm mentioned this issue Feb 16, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@incognitojam @gregjhogan