Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move handleAbort to msg server layer #3824

Closed
3 tasks
colin-axner opened this issue Jun 12, 2023 · 3 comments
Closed
3 tasks

Move handleAbort to msg server layer #3824

colin-axner opened this issue Jun 12, 2023 · 3 comments
Assignees

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Jun 12, 2023

Summary

see discussion, move handle abort to msg server layer so it can call the on restore callback


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added 04-channel needs discussion Issues that need discussion before they can be worked on labels Jun 12, 2023
@colin-axner colin-axner changed the title Consider adding handleAbort helper function Move handleAbort to msg server layer Jul 3, 2023
@damiannolan
Copy link
Member

I think we can possibly leave the MustAbortUpgrade function in 04-channel now? And just add a simple callback to the app within the core/keeper handler:

if upgradeErr, ok := err.(*channeltypes.UpgradeError); ok {
	k.ChannelKeeper.MustAbortUpgrade(ctx, msg.PortId, msg.ChannelId, upgradeErr)

+	cbs.OnChanUpgradeRestore(ctx, msg.PortId, msg.ChannelId)

	// NOTE: a FAILURE result is returned to the client and an error receipt is written to state.
	// This signals to the relayer to begin the cancel upgrade handshake subprotocol.
	return &channeltypes.MsgChannelUpgradeAckResponse{Result: channeltypes.FAILURE}, nil
}

@crodriguezvega crodriguezvega removed the needs discussion Issues that need discussion before they can be worked on label Jul 10, 2023
@damiannolan damiannolan self-assigned this Jul 10, 2023
@DimitrisJim
Copy link
Contributor

bump, issue can be closed yea?

@damiannolan
Copy link
Member

Yeah, I opened #4056 linking to the discussion in PR #4051

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants