Logged targetClient object is always nil when error is returned

[crodriguezvega]

This issue was found by Trail of Bits during the audit of ICS27 Interchain Accounts

Problem Definition

The Keeper.ConnectionOpenTry function calls clienttypes.UnpackClientState to obtain a target client. When clienttypes.UnpackClientState returns an error, the received targetClient object is indicated in the error logs. However, clienttypes.UnpackClientState’s errors always indicate nil for the first returned value. As a result, the returned error will always indicate a nil target client. This reduces the utility of the error. Moreover, based on the error message format (and the %v format specifier), it appears that the developers may have intended the function to log the msg.ClientState instead of the targetClient.

Proposal

Correct the Keeper.ConnectionOpenTry function so that, on error, it returns a message with the intended object.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged/assigned

[crodriguezvega]

We will not log when the error happens.