Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--log-format json should only return json, also --log-format always uses the same format, despite the argument. #1199

Closed
danbryan opened this issue May 21, 2023 · 1 comment · Fixed by #1281
Assignees

Comments

@danbryan
Copy link
Contributor

Example:

rly q balance akash --log-format json

returns...

address {akash1x9fxqdkg4rumkzrck8t3qnhm30jgfsx90ch7fq} balance {38631732uakt}

which is not valid json

Furthermore, it doesn't seem the --log-format does anything. All 3 of these formats are the same.

~ $ rly q balance akash --log-format json
address {akash1x9fxqdkg4rumkzrck8t3qnhm30jgfsx90ch7fq} balance {38631732uakt} 
~ $ rly q balance akash --log-format console
address {akash1x9fxqdkg4rumkzrck8t3qnhm30jgfsx90ch7fq} balance {38631732uakt} 
~ $ rly q balance akash --log-format logfmt
address {akash1x9fxqdkg4rumkzrck8t3qnhm30jgfsx90ch7fq} balance {38631732uakt}
@danbryan
Copy link
Contributor Author

@mark-rushakoff had some thoughts on this too...

https://strangeloveventures.slack.com/archives/C03S6JEEU2W/p1684639261969269

It might be best to add a new --out json for stdout, but leave --log-format for stderr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants