Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of ignore cookies option #64

Open
bfsoares opened this issue May 7, 2024 · 1 comment
Open

Lack of ignore cookies option #64

bfsoares opened this issue May 7, 2024 · 1 comment

Comments

@bfsoares
Copy link

bfsoares commented May 7, 2024

Hi! In a particular case of use of Selenium-Requests I realize that is impossible to ignore cookies when making a request, even using the kwarg cookies=[]. Looking in the code I saw that this option is not used as primary option, but only to give extra cookie(s) for those of the session, that are always used.
To solve my problem, I created the boolean kwarg "ignore_cookies", including the following code in line 209 of request.py file:

    if kwargs.get("ignore_cookies", False):
        del kwargs["ignore_cookies"]
        del kwargs["cookies"]

To make Selenium-Request more robust and useful to other users, I would like to suggest this change for this module.

@Phat-pham99
Copy link

Phat-pham99 commented Jun 1, 2024

Pardon me, but isn't the ultimate goal of Selenium-Requests is to capture the cookies from webdriver to feed it into requests ? Why would you want to ignore cookies ? Instead you can you the old Requests module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants