Skip to content
This repository has been archived by the owner on Jan 27, 2021. It is now read-only.

Improve metrics collection strategy #17

Closed
krancour opened this issue Dec 14, 2018 · 1 comment
Closed

Improve metrics collection strategy #17

krancour opened this issue Dec 14, 2018 · 1 comment
Labels
improvement Requests or implements improvements that are NOT new features

Comments

@krancour
Copy link
Contributor

#15 and #16 will both require us to alter our approach to serving and aggregating metrics, since it is clear that request count is an inadequate metric upon which to make scaling decisions if we are to support protocols other than HTTP (e.g. HTTPS, HTTP2, gRPC).

The new approach may "simply" (it's not actually simple) involve counting active TCP connections over a period of time.

I'd like to suggest avoiding a dependency on Prometheus for as long as it can be avoided, as it raises the barrier to entry for using Osiris. In the near term, we can investigate options for metrics-collecting sidecar proxies to keep time series data in memory, with older data evicted as is become irrelevant.

@krancour krancour added the improvement Requests or implements improvements that are NOT new features label Dec 14, 2018
@krancour krancour pinned this issue Dec 14, 2018
@krancour
Copy link
Contributor Author

This was fixed by #27.

@krancour krancour unpinned this issue May 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
improvement Requests or implements improvements that are NOT new features
Projects
None yet
Development

No branches or pull requests

1 participant