Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup type checking in "--compat" mode #12482

Closed
Tracked by #12577
bartlomieju opened this issue Oct 18, 2021 · 0 comments · Fixed by #15678
Closed
Tracked by #12577

Cleanup type checking in "--compat" mode #12482

bartlomieju opened this issue Oct 18, 2021 · 0 comments · Fixed by #15678
Assignees
Labels

Comments

@bartlomieju
Copy link
Member

Currently in --compat mode during type-checking std/node/global.ts is unconditionally added to the roots of module graph created:

deno/cli/proc_state.rs

Lines 302 to 310 in 71da814

// TODO(bartlomieju): this is very make-shift, is there an existing API
// that we could include it like with "maybe_imports"?
let roots = if self.flags.compat {
let mut r = vec![compat::GLOBAL_URL.clone()];
r.extend(roots);
r
} else {
roots
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants