Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with lsp imports #24889

Open
ry opened this issue Aug 5, 2024 · 4 comments
Open

Issues with lsp imports #24889

ry opened this issue Aug 5, 2024 · 4 comments
Assignees
Labels
feat new feature (which has been agreed to/accepted) lsp related to the language server

Comments

@ry
Copy link
Member

ry commented Aug 5, 2024

Version: Deno 1.45.5

No quickfix for installing npm dependencies

Screenshot 2024-08-05 at 10 39 41 AM

No auto-complete for node:fs/pro
Screenshot 2024-08-05 at 10 45 42 AM

Use "install" instead of "cache" everywhere. For example - change terminology from "Uncached or missing jsr dependency" to "Uninstalled". Or in the quickfix, instead of "Cache jsr:@std/fs/walk and its dependencies" say "Install jsr:@std/fs/walk and its dependencies"
Screenshot 2024-08-05 at 10 42 10 AM
Screenshot 2024-08-05 at 10 42 27 AM

Uncached deps red squiggly should probably be a yellow squiggly. Red is too aggressive.
Screenshot 2024-08-05 at 6 05 56 AM

also #24951

@lucacasonato lucacasonato added feat new feature (which has been agreed to/accepted) lsp related to the language server labels Aug 7, 2024
@lucacasonato
Copy link
Member

I agree with everything here, except:

Uncached deps red squiggly should probably be a yellow squiggly. Red is too aggressive.

It should be a red squiggly - it's the error for when you are importing something that does not exist. import "./doesnotexist.ts" should not be a yellow squiggly either.

@guy-borderless
Copy link

May be nice to also be able to deno add and have the name rewritten

@ry
Copy link
Member Author

ry commented Aug 8, 2024

@lucacasonato

It should be a red squiggly - it's the error for when you are importing something that does not exist. import "./doesnotexist.ts" should not be a yellow squiggly either.

With auto-install common in deno, I don't think this matches the user's experience. jsr:@std/fs/walk does exist, unlike ./doesnotexist.ts. The analogy doesn't hold.

@luizfilipe
Copy link

that would be nice to be on LSP, and also with things on "imports" section on deno.json conf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat new feature (which has been agreed to/accepted) lsp related to the language server
Projects
None yet
Development

No branches or pull requests

5 participants