Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linter shouldn't support eslint ignore directive #8226

Closed
bartlomieju opened this issue Nov 2, 2020 · 0 comments · Fixed by #8292
Closed

Linter shouldn't support eslint ignore directive #8226

bartlomieju opened this issue Nov 2, 2020 · 0 comments · Fixed by #8292
Labels
cli related to cli/ dir user feedback wanted feedback from the community is desired

Comments

@bartlomieju
Copy link
Member

Currently deno lint supports two distinct ways of ignoring diagnostics on next line:

  • eslint-disable-next-line
  • deno-lint-ignore

In denoland/deno_lint#476 @nayeemrmn suggests to make deno-lint-ignore take into account whole AST node which would render eslint-disable-next-line irrelevant. Additionally supporting eslint's directive leads to a subtle bug in deno_lint (denoland/deno_lint#287).

I believe we should remove support for eslint-disable-next-line and stay only with deno-lint-ignore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli related to cli/ dir user feedback wanted feedback from the community is desired
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

upgrade: deno_doc, deno_lint, dprint, swc bartlomieju/deno
1 participant
@bartlomieju