Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable NuGet updater image to support arm64 #10689

Open
brettfo opened this issue Sep 27, 2024 · 1 comment · May be fixed by #10693
Open

Enable NuGet updater image to support arm64 #10689

brettfo opened this issue Sep 27, 2024 · 1 comment · May be fixed by #10693
Labels
L: docker Docker containers L: dotnet:nuget NuGet packages via nuget or dotnet

Comments

@brettfo
Copy link
Contributor

brettfo commented Sep 27, 2024

The NuGet updater image depends on powershell but currently only an amd64 package is provided, not arm64. While production is on amd64 machines, contributors might be on ARM and could benefit from being able to build and run locally.

As of PowerShell version 7.4.5, there is no arm64 .deb file provided for installation, but there is a .tar.gz with pre-built binaries that could be extracted to the image. Docker supports predefined values that can be used to determine the architecture of the underlying machine: https://docs.docker.com/build/building/variables/#multi-platform-build-arguments

@brettfo brettfo added the L: dotnet:nuget NuGet packages via nuget or dotnet label Sep 27, 2024
@github-actions github-actions bot added the L: docker Docker containers label Sep 27, 2024
@andrcuns andrcuns linked a pull request Sep 28, 2024 that will close this issue
5 tasks
@andrcuns
Copy link
Contributor

FYI, I have added PR to fix this issue. It's fairly straight forward, TARGETARCH variable is already used in quite a few other dockerfiles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: docker Docker containers L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants