-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect parsing of environment variable when quoted #168
Comments
I think it would be a relatively straightforward change to make so that Technically, this would be a breaking change. I.e. if someone currently has a value with quotes and wants the quotes then making this change would break the existing usage. But, I suspect that most people would expect the same behaviour that @irarainey did. @chrmarti - what are your thoughts? |
You would then want to support the list for backwards compatibility. I guess that's what you wanted to avoid. :) |
Currently the input is a multiline string that needs to be parsed. The ideal way to do this would be to align with the I couldn't see a way to do that when initially creating the action, and still can't from looking at the |
Any news on this? We just encountered a closely related problem where it currently is not possible to forward multiline secrets through environment variables to the devcontainer. |
I was passing in a URL endpoint as an environment variable to a workflow step to run end-to-end test via Newman, and I was getting a protocol error through by Newman. After some investigation trying to access the same endpoint using wget I noticed that variable being passed in was being parsed incorrectly.
The problem arose when I was calling it like this:
The solution was to remove the quotes around the variable like this:
But as a string I would expect it to be able to handle either format.
The text was updated successfully, but these errors were encountered: