-
Notifications
You must be signed in to change notification settings - Fork 150
Enable TLS support #160
Comments
Currently, many users are terminating TLS via a reverse-proxy of sorts. This feature would require Vault-UI to handle that termination. Totally doable, just not in the priority atm. Would definitely love another one of your PRs, however, if this is a must for you. |
In my opinion, if the roadmap is to eventually make vault-ui "serverless" once Vault releases CORS support, then Vault-UI would just become some static files to be served via whatever server and wouldn't need NodeJS SSL. |
@tallpauley does this PR in vault solve CORS hashicorp/vault#2021 ? here's the documentation in vault: https://www.vaultproject.io/api/system/config-cors.html it seems like it would be enough to begin work on this |
Sorry for the late response, @cpoole, yes it looks like that was released in 0.8.0. @djenriquez do you have any thoughts about making vault-ui front-end only? |
I'm thinking the proper way to handle this would be to have the NodeJS container for development container, and then have something like Nginx or Caddy (automatic https!) for the prod container to serve up the static assets. I don't necessarily have the time to do this right now, just suggesting :) |
@tallpauley if it's truly just front end only I'd say have a docker-compose.yml for development that spins up a vault container and a container with npm watch && npm serve + volume mount. I also dont have a ton of time to contribute right now but this would be something I could tackle in a month or so |
Enable HTTPS based on SSL/TLS of Node.js.
The text was updated successfully, but these errors were encountered: