Skip to content
This repository has been archived by the owner on Mar 27, 2019. It is now read-only.

Enable TLS support #160

Open
lcgkm opened this issue Aug 3, 2017 · 6 comments
Open

Enable TLS support #160

lcgkm opened this issue Aug 3, 2017 · 6 comments

Comments

@lcgkm
Copy link
Contributor

lcgkm commented Aug 3, 2017

Enable HTTPS based on SSL/TLS of Node.js.

@djenriquez
Copy link
Owner

Currently, many users are terminating TLS via a reverse-proxy of sorts. This feature would require Vault-UI to handle that termination. Totally doable, just not in the priority atm. Would definitely love another one of your PRs, however, if this is a must for you.

@tallpauley
Copy link
Collaborator

In my opinion, if the roadmap is to eventually make vault-ui "serverless" once Vault releases CORS support, then Vault-UI would just become some static files to be served via whatever server and wouldn't need NodeJS SSL.

@cpoole
Copy link

cpoole commented Aug 26, 2017

@tallpauley does this PR in vault solve CORS hashicorp/vault#2021 ?

here's the documentation in vault: https://www.vaultproject.io/api/system/config-cors.html

it seems like it would be enough to begin work on this

@tallpauley
Copy link
Collaborator

Sorry for the late response, @cpoole, yes it looks like that was released in 0.8.0. @djenriquez do you have any thoughts about making vault-ui front-end only?

@tallpauley
Copy link
Collaborator

I'm thinking the proper way to handle this would be to have the NodeJS container for development container, and then have something like Nginx or Caddy (automatic https!) for the prod container to serve up the static assets. I don't necessarily have the time to do this right now, just suggesting :)

@cpoole
Copy link

cpoole commented Sep 23, 2017

@tallpauley if it's truly just front end only I'd say have a docker-compose.yml for development that spins up a vault container and a container with npm watch && npm serve + volume mount.

I also dont have a ton of time to contribute right now but this would be something I could tackle in a month or so

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants