Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev(meta): update manifest file to contain extra information #748

Closed
6 tasks done
lambda-0x opened this issue Aug 11, 2023 · 8 comments · Fixed by #1674
Closed
6 tasks done

dev(meta): update manifest file to contain extra information #748

lambda-0x opened this issue Aug 11, 2023 · 8 comments · Fixed by #1674
Labels
good first issue Good for newcomers sozo
Milestone

Comments

@lambda-0x
Copy link
Collaborator

lambda-0x commented Aug 11, 2023

add information like chain_id, block_number on which a particular contract was deployed, transaction_hash of transaction that deployed a contract, salt used to create world, etc...

idea being having this values in manifest file will help other dojo related dev tools to get this values when needed, schema for new manifest file still needs to be decided (any suggestions welcome)

see: #687 for more context

@ponderingdemocritus
Copy link
Contributor

related to #746

@kariy
Copy link
Member

kariy commented Sep 6, 2023

once we include the block number in the manifest.json, let's remove the block number in the cli success text in favour of this.

@tarrencev
Copy link
Contributor

@lambda-0x are you still thinking of working on this? i kind of want to overhaul the manifest system, to use something a more more human readable, modeled after kubernetes manifests

@lambda-0x
Copy link
Collaborator Author

@tarrencev i have been busy with personal work for the time being so don't want to commit to big refactors. if those are split into smaller tasks i can give them a try when i get time.

@lambda-0x lambda-0x removed their assignment Oct 12, 2023
@ponderingdemocritus ponderingdemocritus added the good first issue Good for newcomers label Nov 20, 2023
@ponderingdemocritus
Copy link
Contributor

@tarrencev how important do you think this is? Should we put it in 0.5.0?

@ponderingdemocritus ponderingdemocritus added this to the 0.5.0 milestone Nov 30, 2023
@glihm
Copy link
Collaborator

glihm commented Jan 9, 2024

Blocked by #1231.

Should be done after the rework.

@glihm glihm added the blocked This issue is blocked due to some other issues label Feb 14, 2024
@glihm
Copy link
Collaborator

glihm commented Feb 14, 2024

Block label added until the manifest is reworked to it's new format.

@tarrencev tarrencev removed the blocked This issue is blocked due to some other issues label Mar 6, 2024
@tarrencev tarrencev added the sozo label Mar 6, 2024 — with Linear
@remybar
Copy link
Contributor

remybar commented Mar 11, 2024

Can I work on it ? it would be a good issue to see how manifest files work :)

To summarize, these data still need to be written in the manifest file:

  • block_number on which a particular contract was deployed,
  • transaction_hash of transaction that deployed a contract
  • seed used to create world

is it correct ? other things ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers sozo
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants