Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HasNativeCodeReJitAware #89475

Closed
mikelle-rogers opened this issue Jul 25, 2023 · 2 comments
Closed

HasNativeCodeReJitAware #89475

mikelle-rogers opened this issue Jul 25, 2023 · 2 comments
Assignees
@mikelle-rogers
Labels
area-Diagnostics-coreclr
Milestone
8.0.0

Comments

@mikelle-rogers
Copy link
Member

mikelle-rogers commented Jul 25, 2023 •
edited
Loading

Check uses of EEDebugInterface::GetFunctionAddress and see if we should return nondefault code addresses.
HasNativeCodeReJitAware is only checking if the active or default versions have native code. It's possible that a non-active, non-default version has code even if both the active and default versions do not.
Delete HasNativeCodeReJitAware and move its functionality to GetFunctionAddress.
@mikelle-rogers mikelle-rogers added this to the 8.0.0 milestone Jul 25, 2023
@mikelle-rogers mikelle-rogers self-assigned this Jul 25, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 25, 2023
@ghost
Copy link

ghost commented Jul 26, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

HasNativeCodeReJitAware is only checking if the active or default versions have native code. It's possible that a non-active, non-default version has code even if both the active and default versions do not.

Author: mikelle-rogers
Assignees: mikelle-rogers
Labels:

area-Diagnostics-coreclr, needs-area-label
Milestone: 8.0.0

@vcsjones vcsjones removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 26, 2023
@mikelle-rogers mikelle-rogers mentioned this issue Aug 4, 2023
Merged
@tommcdon
Copy link
Member

Closing via #90049

@ghost ghost locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mikelle-rogers mikelle-rogers

Labels
area-Diagnostics-coreclr
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
4 participants
@vcsjones @jeffschwMSFT @tommcdon @mikelle-rogers