Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

case insensitive tag names doesn't seem to work after updating to 2.2.7 from 2.2.2 #100

Open
Manvel opened this issue Feb 6, 2024 · 7 comments

Comments

@Manvel
Copy link

Manvel commented Feb 6, 2024

Hey nwsapi team 👋

In our company we highly rely on JSDom(which seem to be using nwsapi for selectors resolution) and when doing the package resolution, we have realized that with update to nwsapi, the Uppercase tag name selector stopped working in our tests.

It seems like this issue has been reported previously and resolved, but apparently it's back(unless missing something).

@dperini
Copy link
Owner

dperini commented Feb 18, 2024

@Manvel currently I fixed this for HTML docs only, previously we had it resolve correctly also for XML docs using:

        source = 'if(' + N + '(e.localName' +
          (Config.MIXEDCASE || hasMixedCaseTagNames(doc) ?
            '=="' + match[1].toLowerCase() + '"' :
            '=="' + match[1].toUpperCase() + '"') +
          ')){' + source + '}';

As you can see we have had a Config.MIXEDCASE configuration flag to force resolution in both HTML and XML documents.
There was also an auto-detection method 'hasMixedCaseTagNames(doc)' used as alternate way to detect MixedCase.
At that time it was decided to remove this functionality but we can easily reintroduce it.

Thank you for your help and contribution, much needed and appreciated.

@Manvel
Copy link
Author

Manvel commented Feb 18, 2024

Thanks @dperini, think in that case current ticket and #101 can be closed?

Please let me know when the release is out, so I try following up with JSDom to update the dependencies.

@Manvel
Copy link
Author

Manvel commented Mar 1, 2024

Hey @dperini 👋 Is there an ETA on the upcoming release by any chance? Thanks in advance.

@dperini
Copy link
Owner

dperini commented Mar 1, 2024

@Manvel I am sorry I have been recovered to hospital since the beginning of this week.
I couldn't do what I promise and this was the trend for all this last year.
Though I don't want to give up and hope to be home next Monday.

@Manvel
Copy link
Author

Manvel commented Mar 1, 2024

@Manvel I am sorry I have been recovered to hospital since the beginning of this week.

I couldn't do what I promise and this was the trend for all this last year.

Though I don't want to give up and hope to be home next Monday.

Ohh, sorry to hear that, no worries about delaying the release. If anything I can help lmk.

@Manvel
Copy link
Author

Manvel commented Jul 4, 2024

hey @dperini just checking back on this, I assume there is still no progress here? I gave another try updating our tooling and hit same issue. So wanted to ping just in case.

@dperini
Copy link
Owner

dperini commented Jul 4, 2024

@Manvel
can you check and see if the latest change did fix your problem ?
If it is not fixed submit a minimal example showing the problem.
I will then be able to retake this issue by reintroducing older code.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants