Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RotatedText code does not dispose created TextLayout #1200

Closed
hvbtup opened this issue Feb 3, 2023 · 3 comments · Fixed by #1203
Closed

RotatedText code does not dispose created TextLayout #1200

hvbtup opened this issue Feb 3, 2023 · 3 comments · Fixed by #1203
Assignees
@priytosh-tripathi
Labels
Easy! You can do this!
Milestone
4.13

Comments

@hvbtup
Copy link
Contributor

hvbtup commented Feb 3, 2023

When the RotatedTextItem plugin is used in a report, an SWT warning about a "missing dispose" is shown in the error log(?) in the designer.

For a solution, see the change to the Java source file SwtGraphicsUtil.java in my cancelled PR #1084.
@hvbtup hvbtup added the Easy! You can do this! label Feb 3, 2023
@priytosh-tripathi
Copy link
Contributor

Hi @hvbtup ,

Can you please assign this task to me?

@priytosh-tripathi
Copy link
Contributor

Hi @hvbtup ,

Please find the following PR for review:
#1203

@wimjongman wimjongman added this to the 4.13 milestone Feb 7, 2023
@wimjongman wimjongman linked a pull request Feb 7, 2023 that will close this issue
Fix RotatedText #1203
Merged
@wimjongman wimjongman changed the title SWT warning in RotatedText Item extension tutorial RotatedText code does not dispose created TextLayout Feb 7, 2023
@wimjongman
Copy link
Contributor

Thanks for this, Priytosh!

@hvbtup hvbtup closed this as completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@priytosh-tripathi priytosh-tripathi

Labels
Easy! You can do this!
Projects
None yet
Milestone
4.13
Development

Successfully merging a pull request may close this issue.

Fix RotatedText priytosh-tripathi/birt
3 participants
@wimjongman @hvbtup @priytosh-tripathi