Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fragment files copied to Helm output directories #2397

Closed
manusa opened this issue Sep 28, 2023 · 2 comments · Fixed by #2403
Closed

Fragment files copied to Helm output directories #2397

manusa opened this issue Sep 28, 2023 · 2 comments · Fixed by #2403
Assignees
Labels
bug Something isn't working component/helm ⎈
Milestone

Comments

@manusa
Copy link
Member

manusa commented Sep 28, 2023

Description

Helm source fragment files (Chart.helm.yaml and values.helm.yaml) are copied to the Helm output directory ((target|build)/jkube).

These are source files that shouldn't be propagated in their raw state.

@manusa manusa added bug Something isn't working component/helm ⎈ labels Sep 28, 2023
@manusa manusa self-assigned this Sep 28, 2023
@manusa manusa added this to the 1.15.0 milestone Sep 28, 2023
@manusa
Copy link
Member Author

manusa commented Sep 28, 2023

This also affects other fragments. Might be just the default behavior. Further analysis is needed.

@manusa manusa changed the title Helm fragment files copied to Helm output directories Fragment files copied to Helm output directories Sep 28, 2023
@manusa
Copy link
Member Author

manusa commented Sep 28, 2023

The behavior is fine, since this is also the working directory which is used by the DefaultResourceService to pre-process resources.

The directory is configured by means of jkube.workDir which defaults to ${project.build.directory}/jkube.

Since this directory is for internal use, and shouldn't really affect users, I propose to change it to jkube-temp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component/helm ⎈
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant