Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildRecreateMode: Remove unnecessary private modifier in enum constructor #3287

Closed
rohanKanojia opened this issue Jul 31, 2024 · 1 comment · Fixed by #3301
Closed

BuildRecreateMode: Remove unnecessary private modifier in enum constructor #3287

rohanKanojia opened this issue Jul 31, 2024 · 1 comment · Fixed by #3301
Assignees
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers
Milestone

Comments

@rohanKanojia
Copy link
Member

rohanKanojia commented Jul 31, 2024

Description

There is no need to add private modifier before constructor as constructors are by default private for enum types

private BuildRecreateMode(boolean bc, boolean is) {

should be changed to:

    BuildRecreateMode(boolean bc, boolean is) {

🔴 Before you start 🔴

👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇

Make sure you read the contributing guide first.

Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

This is a first-timers-only issue. These issues are especially created for contributors who are contributing to the project for the first time.

If you have already contributed to this project in the past, please don't ask to be assigned one of these issues and look for good-first-issues or help-wanted issues instead in order to continue you contributor journey in the project.

@rohanKanojia rohanKanojia added good first issue Good for newcomers first-timers-only Is this your first time contributing? This could be a good place to start! labels Jul 31, 2024
@rohanKanojia rohanKanojia changed the title BuildRecreateMode : Remove unnecessary private modifier BuildRecreateMode : Remove unnecessary private modifier in enum constructor Jul 31, 2024
@Switchharsh
Copy link
Contributor

Hi, I would like to work on it.

@manusa manusa added this to the 1.17.0 milestone Aug 5, 2024 — with automated-tasks
@manusa manusa changed the title BuildRecreateMode : Remove unnecessary private modifier in enum constructor BuildRecreateMode: Remove unnecessary private modifier in enum constructor Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers
Projects
None yet
3 participants