Replies: 4 comments 11 replies
-
I don't agree that value_selector is poorly named. It clearly states that it is about how you pick the values you are interested in and that includes both the predicate as well as the projection. Properties can also be seen as additional context to specify how to choose the value. Additionally if makes a nice tandem with key_selector. I am not convinced we need to change it and I find that the e proposal above make less intuitive for a user to get a hint of what it does. |
Beta Was this translation helpful? Give feedback.
-
As part of the basic Zenoh API, what comes after So, the fact that it might look "less intuitive for a user to get a hint of what it does" to me is actually proving the point that Finally, I think that our |
Beta Was this translation helpful? Give feedback.
-
The A So we need the
Even if any character can be represented via percent-encoding, it would me more performant and user-friendly to stick with those characters.
Therefore, the new format of the
At this stage, we plan to make use of those reserved keys:
|
Beta Was this translation helpful? Give feedback.
-
As discussed the consensus is to change the name to |
Beta Was this translation helpful? Give feedback.
-
Currently,
Selector
is defined by akey_selector
and avalue_selector
.We recently decided to expose the
value_selector
as a simple string for0.6.0
, with the intent of providing good parsers inzenoh-ext
later.However, we might as well take this chance to rename these fields:
key_selector
becomeskey_expr
easily, making the use ofkey_expr
consistent everywhere when you want to access something's key expression.value_selector
is very poorly named: it used to mirrorkey_selector
, but that section of the selector can have arbitrary content and is often used to carry arguments rather than act as a selector that looks at the value.8 votes ·
Beta Was this translation helpful? Give feedback.
All reactions