Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

old layouts for defaults used in final layout #522

Open
jeffdi opened this issue Jan 10, 2024 · 3 comments
Open

old layouts for defaults used in final layout #522

jeffdi opened this issue Jan 10, 2024 · 3 comments
Assignees

Comments

@jeffdi
Copy link
Collaborator

jeffdi commented Jan 10, 2024

No description provided.

@RTimothyEdwards
Copy link
Contributor

Ultimately comes down to line 242 of scripts/gen_gpio_defaults.py:

        if not os.path.isfile(mag_file):

This line can be removed, but I think it may be better to add a warning before overwriting files, or let the script fail.

        if os.path.isfile(mag_file):
            print('Warning:  Existing file ' + mag_file + ' exists and will be overwritten.')
            os.remove(mag_file)

        if not os.path.isfile(mag_file):
            ...

@d-m-bailey
Copy link
Contributor

#102 should fix this.

@DavidRLindley
Copy link
Contributor

We think this is solved but not verified. The LVS check we are implementing should catch this issue. We can close when the LVS issue closes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants