Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiPageContent] Add prop withPanel to control whether the component is styled as an EuiPanel #4192

Closed
j-m opened this issue Oct 28, 2020 · 5 comments
Closed

[EuiPageContent] Add prop withPanel to control whether the component is styled as an EuiPanel #4192

j-m opened this issue Oct 28, 2020 · 5 comments
Assignees
@cchaos
Labels
design decision feature request

Comments

@j-m
Copy link
Contributor

j-m commented Oct 28, 2020

I avoid using EuiPageContent because it has panel styling, but its alignment props are very useful.
It would be nice to have a withPanel prop like EuiDroppable's.
@cchaos
Copy link
Contributor

cchaos commented Oct 28, 2020

I am currently working towards increasing visual options of EuiPanel which we could then expose to EuiPageContent.

@cchaos cchaos self-assigned this Oct 28, 2020
@j-m
Copy link
Contributor Author

j-m commented Jan 31, 2021

@cchaos Is there a ticket for the work on EuiPanel? If so this issue can be closed :)

@cchaos
Copy link
Contributor

cchaos commented Feb 1, 2021

No there isn't a specific ticket, but PR #4194 got us a step closer. I'm continuing to do work on the page components for an internal effort, so there will probably be more options in the future.

@j-m
Copy link
Contributor Author

j-m commented Feb 26, 2021

@cchaos Does #4525 close this?

@cchaos
Copy link
Contributor

cchaos commented Mar 2, 2021

Yep, thanks! Closed by #4525

@cchaos cchaos closed this as completed Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cchaos cchaos

Labels
design decision feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cchaos @thompsongl @j-m