Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiComboBox] Clearable functionality should work during text search/typing #5498

Open
Tracked by #182611
cchaos opened this issue Dec 21, 2021 · 5 comments
Open
Tracked by #182611

Comments

@cchaos
Copy link
Contributor

cchaos commented Dec 21, 2021

At least with single selection turned on, the clearable button only exists when you have an item selected. But to easily clear something that was typed, it would be good to have the clearable button show up before a selection has been made, but when there is text in the input.

There is also a bug where if you clear the current selection by typing to find a new item, the clearable button still exists, but clicking it doesn't actually clear anything.

Screen.Recording.2021-12-21.at.12.18.58.PM.mp4
@cchaos
Copy link
Contributor Author

cchaos commented Dec 21, 2021

The clear functionality in EuiComboBox does not clear invalid options: eui

I discovered this through this bug report: elastic/kibana#120609

We have a reset button that "resets" the selectedOptions prop. However, this does not clear invalid options either. I'm not sure if fixing the clear problem will fix our problem or if we need a clear handler?

Originally posted by @stephmilovic in #5500

@JasonStoltz
Copy link
Member

@cee-chen Any idea if this will be fixed by #2841?

@cee-chen
Copy link
Member

No, EuiComboBox will likely need its own custom input still, so will need some manual fixing.

@teresaalvarezsoler
Copy link

I cannot find this experience in the dashboards/lens/discover UI anywhere. Do you know if this has been implemented anywhere? Otherwise I think it's fine postponing it until there is a real use case.

@JasonStoltz
Copy link
Member

@timductive Did you have a specific location this is used in mind?

@github-actions github-actions bot added the Stale label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants