New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more specific with the widget permissions #2932

Closed

stefanceriu opened this issue May 28, 2024 · 1 comment · Fixed by #2947

Assignees

Labels

Member

stefanceriu commented May 28, 2024

From element-x-ios created by toger5: element-hq/element-x-ios#1997

Currently we just approve all of them in the permission callback from the rust sdk.
In EW we only approve what the widget is allowed to:
https://github.com/matrix-org/matrix-react-sdk/blob/d405e85cec36cbc2d15e652726008ebfaca9daab/src/stores/widgets/StopGapWidgetDriver.ts#L123-L178

This should also be done on andoid/ios.

stefanceriu added A-VOIP T-Task labels

Member Author

stefanceriu commented May 28, 2024

RustSDK update to fix the permissions here ffi: Fix get_element_call_required_permissions matrix-org/matrix-rust-sdk#3455
iOS PR adopting it here Fixes #1997 - Be more specific with the widget permissions element-x-ios#2885

bmarty self-assigned this

bmarty mentioned this issue

Be more specific with the widget permissions #2947

Merged

14 tasks

bmarty closed this as completed in #2947

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment