Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sha256 a la base64 #2335

Open
dckc opened this issue Jun 27, 2024 · 1 comment
Open

add sha256 a la base64 #2335

dckc opened this issue Jun 27, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@dckc
Copy link
Contributor

dckc commented Jun 27, 2024

What is the Problem Being Solved?

Importing sha256 from @cosmjs/crypto failed trying to import node:crypto. Attempts to work around that using a newer @noble/hashes ran into a limitation around package exports:

Description of the Design

sketch: Agoric/agoric-sdk#9576 (comment)

cc @kriskowal

Security Considerations

sha256 callers rely on cryptographic hash properties (other than constant time)

Scaling Considerations

I'm not currently aware of a need to hash large quantities of data, so dropping down to native code isn't likely to have a significant impact.

Test Plan

@noble/hashes is extensively tested; any deviation should be carefully tested.

Compatibility / Upgrade Considerations

This would be a new feature.

@turadg
Copy link
Member

turadg commented Jul 12, 2024

ran into a limitation

Circumvented in #9576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants