Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add find* to gain alignment with react-test-renderer #117

Open
k2snowman69 opened this issue Nov 16, 2022 · 0 comments
Open

Feature: Add find* to gain alignment with react-test-renderer #117

k2snowman69 opened this issue Nov 16, 2022 · 0 comments

Comments

@k2snowman69
Copy link

It seems that react-test-renderer exports this package under react-test-renderer/shallow to support shallow rendering. However this package doesn't contain the low level "find" functions that make it easy to dive into a shallow component similar to react-test-renderer's default export.

The ask is to implement the following functions for consistency:

I know enzyme "provides a nicer higher-level API over the same functionality" my ask is to provide even basic low level to have alignment between shallow and deep core rendering engines.

I think we could probably just copy most of the logic for the deep renderer here and it should get us 80% of the way.

Then in the future Enzyme could update to use these lower level functions to help fuel it's higher level functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant