Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message is wrong if in case if position indicator in IDT code contradicts real position of the monomer in the chain #1984

Closed
AlexeyGirin opened this issue Jun 5, 2024 · 2 comments · Fixed by #2019

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jun 5, 2024

Steps to Reproduce

  1. Load following IDT string using Paste from Clipboard way: /32MOErC/*/32MOErT/
    image

Actual behavior
System throws an error: Convert error! Given string could not be loaded as (query or plain) molecule or reaction, see the error messages: 'SEQUENCE loader: IDT alias 32MOErC not found at five-prime end position.'
image

Expected behavior
System throws an error: Position of monomer 1 in sequence contradicts its code
image

As per requirement:

In case if position indicator in IDT code contradicts real position of the monomer in the chain,
this should be treated as format error and import should fail with appropriate error message:
Position of monomer <IDT id> in sequence contradicts its code

Versions:

  • Indigo Toolkit Version 1.21.0-rc.1.0-g9194599b2-wasm32-wasm-clang-19.0.0
  • Ketcher Version 2.22.0-rc.2 Build at 2024-06-03; 18:43:00
  • Chrome Version 125.0.6422.142 (Official Build) (64-bit)
  • Windows 10

Issue found while testing #1899

@AnnaKosol
Copy link
Collaborator

The problem is still reproduced (the code is missing in the release branch for version 2.23.0-rc.1)
Снимок экрана 2024-07-03 в 14 45 41
Expected result:
System throws an error: Position of monomer 1 in sequence contradicts its code

@AnnaKosol AnnaKosol reopened this Jul 3, 2024
@AlexeyGirin
Copy link
Collaborator Author

AlexeyGirin commented Jul 5, 2024

Verified.
Agreed with @olganaz and @ljubica-milovic that currect implementation (i.e. error message) is acceptable
image

  • Ketcher Version 2.22.0-rc.9 Build at 2024-07-04; 15:58:14
  • Indigo Toolkit Version 1.21.0-rc.3.0-g1570d3f9f-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 126.0.6478.127 (Official Build) (64-bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants