Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position pathway reaction on canvas #2052

Closed
yauhen-karmyzau opened this issue Jul 2, 2024 · 1 comment
Closed

Position pathway reaction on canvas #2052

yauhen-karmyzau opened this issue Jul 2, 2024 · 1 comment
Assignees
Labels
Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes

Comments

@yauhen-karmyzau
Copy link
Collaborator

yauhen-karmyzau commented Jul 2, 2024

As a User, I want to open a reaction tree from an RDF file and display it in Ketcher's canvas, So that I can have a visual representation of the reaction data contained in the RDF file.

Acceptance Criteria:

  1. When I upload an RDF file, the application should parse the file and build a reaction tree based on the data.
  2. The reaction tree should be displayed in Ketcher's canvas in a clear and understandable manner.
  3. The reaction tree should accurately represent the data in the RDF file, with each node corresponding to a reaction and each edge representing the relationship between reactions.
  4. If a user uploads RXN file, a single reaction with “+” and a single arrow should be displayed (as it is).
  5. The application should handle errors in the RDF file gracefully, displaying an appropriate error message if the file cannot be parsed or the reaction tree cannot be built.
  6. The multi-tail arrow connection of reactions in the tree is not required in this feature;
  7. We should use a sequence as in file, as soon as matching is done it's applied
  8. Here is an implementation for recognition only of one pathway reaction as in the use case
  9. Reagents should be ignored
  10. (Out of scope) - Single arrow will be presented instead of multi-arrow.

**Here is an implementation for recognition of only one first pathway reaction as in the use case, edge cases are out of scope, **

  1. If there are reactions or elements in the RDF file that are not included in the reaction tree, these should be placed below the reaction tree in the canvas.
  2. Currently we are ignoring reagents for loading from RDF
  3. Meta data rendering will implemented in scope of other story.
@yauhen-karmyzau yauhen-karmyzau changed the title Position on canvas as a tree Position multi-tail reaction on canvas Jul 3, 2024
@yauhen-karmyzau yauhen-karmyzau added the MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes label Jul 8, 2024
@yauhen-karmyzau yauhen-karmyzau changed the title Position multi-tail reaction on canvas Position pathway reaction on canvas Jul 15, 2024
@yauhen-karmyzau yauhen-karmyzau added this to the Indigo-1.23.0-rc.1 milestone Jul 16, 2024
@yauhen-karmyzau yauhen-karmyzau removed this from the Indigo-1.23.0-rc.1 milestone Jul 31, 2024
@yauhen-karmyzau yauhen-karmyzau added this to the Indigo-1.24.0-rc.1 milestone Aug 19, 2024
@ivanmaslow
Copy link
Collaborator

This task will be tested in scope of #2128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes
Projects
None yet
Development

No branches or pull requests

3 participants
@ivanmaslow @yauhen-karmyzau and others