Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow some users to scan (inotify integration) #274

Open
kdx2a opened this issue Oct 23, 2022 · 6 comments
Open

Allow some users to scan (inotify integration) #274

kdx2a opened this issue Oct 23, 2022 · 6 comments

Comments

@kdx2a
Copy link

kdx2a commented Oct 23, 2022

Hello! Is there a it way to allow some users other than the admin to "scan now" manually? Or even all of them if there is no simple option. Thank you!

@epoupon
Copy link
Owner

epoupon commented Oct 23, 2022

Hi! For now no it is not possible if you are not the admin user.
What is your use case? Maybe the scan every hour option is an acceptable solution?

@kdx2a
Copy link
Author

kdx2a commented Oct 23, 2022

Thank you for answering!
We are two users adding music on our instance, and we both occasionally need to scan.
The scan every hour option is the solution we are currently using, however it can be a bit frustrating to wait for so long. Would it be possible to have a shorter update window, for example every 5 minutes?

@epoupon
Copy link
Owner

epoupon commented Oct 23, 2022

Maybe it is also time to consider watching directories for changes...

@epoupon epoupon added this to the v3.35.0 milestone Dec 17, 2022
@epoupon epoupon pinned this issue Dec 18, 2022
@epoupon epoupon modified the milestones: v3.35.0, v3.36.0 Jan 1, 2023
@epoupon epoupon changed the title allow some users to scan Allow some users to scan (inotify integration) Jan 15, 2023
@epoupon epoupon modified the milestones: v3.36.0, v3.37.0 Feb 23, 2023
@epoupon epoupon modified the milestones: v3.37.0, v3.38.0 Apr 2, 2023
@epoupon epoupon modified the milestones: v3.38.0, v3.39.0 Apr 21, 2023
@epoupon epoupon modified the milestones: v3.39.0, v3.40.0 May 1, 2023
@epoupon epoupon removed this from the v3.40.0 milestone Oct 18, 2023
@epoupon epoupon unpinned this issue Oct 18, 2023
@parisni
Copy link

parisni commented May 17, 2024

@epoupon what is the status of inotify integration ? such feature would have benefits:

  • real time track addition
  • scanner optimization (no need to scan the whole)

@epoupon
Copy link
Owner

epoupon commented May 17, 2024

Hello!
Currently diff scans are not that long (on my test base, something like 10s for 50k tracks).
I think the benefits would be more on the realtime additions.
I once started to write the code for it, in a dedicated branch. The most problematic point was to raise the default limits to be able to watch each directory (inotify.max_user_watches iirc), not checked how this would behave in a docker container.
There were other problems I don't remember exactly, as I changed a lot the scanner code since my last try. I would need to redig into this to tell you.

@parisni
Copy link

parisni commented May 18, 2024

Sounds like docker should work well with inotify, except on windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants