Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ChaCha20Rng zeroizable #165

Open
kustosz opened this issue Dec 17, 2022 · 3 comments
Open

Make ChaCha20Rng zeroizable #165

kustosz opened this issue Dec 17, 2022 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@kustosz
Copy link
Collaborator

kustosz commented Dec 17, 2022

ChaCha20Rng does not currently implement Zeroize. It seems like there is no trivial way to implement it, so it either requires an upstream contribution or unsafe memory fiddling. Either way, this behavior should be implemented and used in batch_contribution::derive_taus.

@kustosz kustosz added the help wanted Extra attention is needed label Dec 17, 2022
@kustosz
Copy link
Collaborator Author

kustosz commented Dec 19, 2022

Judging by the discussions in rust-random/rand#934, an upstream contribution could be considered.

@MohammadAbuzar945

This comment was marked as spam.

@nstilt1
Copy link

nstilt1 commented Sep 30, 2023

I've submitted a pull request for rand_chacha's dependency, and I have some code available for rand_chacha once the ppv_lite86 PR gets approved, but it requires a Cargo.toml change that includes the next version of ppv_lite86 before rand_chacha can be updated. After rand_chacha is updated, this repo should be able to be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants