From 82ec9b74ed6744f20cc583844563f6ee0ef6e84a Mon Sep 17 00:00:00 2001 From: sebastienlorber Date: Fri, 23 Jun 2023 19:10:15 +0200 Subject: [PATCH] temp fix for html multi-line comments --- packages/docusaurus-mdx-loader/package.json | 2 +- .../docusaurus-mdx-loader/src/processor.ts | 3 ++- website/docusaurus.config.js | 3 --- yarn.lock | 18 +++++++++--------- 4 files changed, 12 insertions(+), 14 deletions(-) diff --git a/packages/docusaurus-mdx-loader/package.json b/packages/docusaurus-mdx-loader/package.json index 94e6235631ad..235b74710da1 100644 --- a/packages/docusaurus-mdx-loader/package.json +++ b/packages/docusaurus-mdx-loader/package.json @@ -24,6 +24,7 @@ "@docusaurus/utils": "3.0.0-alpha.0", "@docusaurus/utils-validation": "3.0.0-alpha.0", "@mdx-js/mdx": "^2.1.5", + "@slorber/remark-comment": "^1.0.0", "escape-html": "^1.0.3", "estree-util-value-to-estree": "^2.1.0", "file-loader": "^6.2.0", @@ -33,7 +34,6 @@ "mdast-util-mdx": "^2.0.0", "mdast-util-to-string": "^3.0.0", "rehype-raw": "^6.1.1", - "remark-comment": "^1.0.0", "remark-directive": "^2.0.1", "remark-emoji": "^2.2.0", "remark-gfm": "^3.0.1", diff --git a/packages/docusaurus-mdx-loader/src/processor.ts b/packages/docusaurus-mdx-loader/src/processor.ts index 906fe65e2136..2683b66693d6 100644 --- a/packages/docusaurus-mdx-loader/src/processor.ts +++ b/packages/docusaurus-mdx-loader/src/processor.ts @@ -76,7 +76,8 @@ async function createProcessorFactory() { const {createProcessor: createMdxProcessor} = await import('@mdx-js/mdx'); const {default: rehypeRaw} = await import('rehype-raw'); const {default: gfm} = await import('remark-gfm'); - const {default: comment} = await import('remark-comment'); + // TODO using fork until PR merged: https://github.com/leebyron/remark-comment/pull/3 + const {default: comment} = await import('@slorber/remark-comment'); const {default: directive} = await import('remark-directive'); // /!\ this method is synchronous on purpose diff --git a/website/docusaurus.config.js b/website/docusaurus.config.js index b97ac2a427cd..c4e7e761bf81 100644 --- a/website/docusaurus.config.js +++ b/website/docusaurus.config.js @@ -163,9 +163,6 @@ module.exports = async function createConfigAsync() { // comments: false, }, preprocessor: ({filePath, fileContent}) => { - // TODO temporary quick fix for https://github.com/facebook/docusaurus/issues/9084 - fileContent = fileContent.replaceAll('