RCTBridge never dealloc

[punan]

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

1. react-native -v: 0.47.0
2. node -v: v8.1.2
3. npm -v: 5.3.0
4. yarn --version: not use

Then, specify:

• Target Platform: iOS

• Development Operating System: macOS

• Build tools: Xcode

Steps to Reproduce

(Write your steps here:)

1.create new project
react-native init demo
2. create a new ViewController, and delete all the code in AppDelegate
3.add the RCTRootView to ViewController

@implementation ViewController

- (void)viewDidLoad {
    [super viewDidLoad];
    NSURL *jsCodeLocation;
  
    jsCodeLocation = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index.ios" fallbackResource:nil];
  
    RCTRootView *rootView = [[RCTRootView alloc] initWithBundleURL:jsCodeLocation
                                                        moduleName:@"demo"
                                                 initialProperties:nil
                                                     launchOptions:nil];
  rootView.frame = self.view.frame;
  [self.view addSubview:rootView];
}

@end

4、run the project

Expected Behavior

When the ViewController has been popped from UINavigationController, the RCTRootView and RCTBridge has to call dealloc methos

Actual Behavior

ViewController and RCTRootView has called dealloc method, but RCTBridge hasn't call dealloc, become leak.

I use debug memory graph, it shows ViewControll and RCTRootView has been released, but when open ViewController again and again, the number of RCTBrigde will increase, the memory also increase

Reproducible Demo

Demo Link
I try to fix the issue, add [_bridge invalidate] to RCTRootView dealloc method. It works, RCTBridge calls dealloc methods when RCTRootView dealloc.

RCTRootView

- (void)dealloc
{
  [[NSNotificationCenter defaultCenter] removeObserver:self];
  [_contentView invalidate];
  [_bridge invalidate];
}

[shergin]

Probably fixed in 1f9fc0e .

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.

[sdyxch]

same issue, The ViewController and RCTRootView has been released, but RCTBridge never.
I rollback to BatchedBridge, it works..
for react-native: 0.49.5

[312362115]

still on 0.53.0

[edison0951]

still on 0.51.0

[edison0951]

We must set [_bridge invalidate] so that the relative resource can be release

[seuzxh]

Same issue with version 0.54.2, RCTBridge cannot be dealloced
I found following codes will fix this issue

// RCTRootView.m
- (void)dealloc
{
  [[NSNotificationCenter defaultCenter] removeObserver:self];
  [_contentView invalidate];
 // Add following codes
  [_bridge invalidate];
  _bridge = nil;
}

But it seems RN doesn't want to fix this issue

[vvlee]

still on 0.55.4

But I don't agree with @seuzxh solution, that is because bridge maybe used to multi RCTRootView.

[arslan2012]

still on 0.56.0 lol wtf