Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Uniqueness test on unique_invoice_line_item_id #73

Closed
2 of 4 tasks
lsusie opened this issue Apr 1, 2024 · 4 comments · Fixed by #74
Closed
2 of 4 tasks

[Bug] Uniqueness test on unique_invoice_line_item_id #73

lsusie opened this issue Apr 1, 2024 · 4 comments · Fixed by #74
Assignees
Labels
bug Something isn't working error:unforced priority:p2 Affects most users; fix needed status:accepted Scoped and accepted into queue type:bug Something is broken or incorrect update_type:testing Primary focus requires testing updates

Comments

@lsusie
Copy link

lsusie commented Apr 1, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Describe the issue

An error in my Fivetran/Stripe package today with uniqueness in stg_stripe_invoice_line_items model.
Seems to be testing for uniqueness on unique_invoice_line_item_id but I have a few records where it is not unique through the data source.

Relevant error log or model output

17:49:29 3 of 3 START test unique_stg_stripe__invoice_line_item_unique_invoice_line_item_id  [RUN]
17:49:30 3 of 3 FAIL 3 unique_stg_stripe__invoice_line_item_unique_invoice_line_item_id . [FAIL 3 in 1.09s]

Expected behavior

As this stg_stripe_invoice_line_items has 2 PK's I expect the unique_stg_stripe__invoice_line_item_unique_invoice_line_item_id to not exist.

dbt_utils_unique_combination_of_columns_stg_stripe__invoice_line_item_invoice_line_item_id__invoice_id__source_relation is already there to ensure the combo is unique

dbt Project configurations

  #### Variables for Fivetran/stripe package ####
  # stripe_database: database
  stripe_schema: source_ft_stripe 

  stripe__using_invoices:        True  #Disable if you are not using the invoice and invoice_line_item tables
  stripe__using_payment_method:  False  #Disable if you are not using the payment_method and payment_method_card tables
  stripe__using_subscriptions:   True  #Disable if you are not using the subscription and plan/price tables.
  stripe__using_credit_notes:    False   #Enable if you are using the credit note tables.

Package versions

  - package: fivetran/stripe
    version: [">=0.12.0", "<0.13.0"]

What database are you using dbt with?

bigquery

dbt Version

18:16:55 Running with dbt=1.6.11

Additional Context

Screenshot 2024-04-01 at 11 21 32 AM

I think you just need to remove this test?

unnamed (2)

Are you willing to open a PR to help address this issue?

  • Yes.
  • Yes, but I will need assistance and will schedule time during our office hours for guidance
  • No.
@lsusie lsusie added the bug Something isn't working label Apr 1, 2024
@fivetran-reneeli
Copy link
Contributor

Thanks @lsusie for creating this very detailed ticket! We'll look to add this fix in the coming weeks.

@fivetran-joemarkiewicz fivetran-joemarkiewicz added priority:p2 Affects most users; fix needed type:bug Something is broken or incorrect status:accepted Scoped and accepted into queue update_type:testing Primary focus requires testing updates error:unforced labels Apr 4, 2024
@fivetran-reneeli fivetran-reneeli self-assigned this Apr 9, 2024
@fivetran-reneeli fivetran-reneeli linked a pull request Apr 9, 2024 that will close this issue
7 tasks
@fivetran-reneeli
Copy link
Contributor

Hi @lsusie ! We've got the ball rolling and will work to get this released in the coming week. In the meantime, feel free to use the following branch with the update. You'll need adjust the packages.yml in your stripe package. Let me know if there are any issues!

  - git: https://github.com/fivetran/dbt_stripe.git
    revision: bugfix/invoice_line_item_uniqueness_test
    warn-unpinned: false

@fivetran-reneeli
Copy link
Contributor

fivetran-reneeli commented Apr 17, 2024

Thanks @lsusie for opening this! We've releasee this update and as such will close this issue out.

@lsusie
Copy link
Author

lsusie commented Apr 17, 2024

@fivetran-reneeli Awesome! Thanks for all the work you and your team does!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working error:unforced priority:p2 Affects most users; fix needed status:accepted Scoped and accepted into queue type:bug Something is broken or incorrect update_type:testing Primary focus requires testing updates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants